Handle ongoing engagement in EntryWidget #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
force-pushed
the
Handle-ongoing-engagement-in-EntryWidget
branch
2 times, most recently
from
6cb5b6f to
e01f846
Compare
rasmustautsglia
requested review from
igorkravchenko,
EgorovEI and
ykyivskyi-gl
EgorovEI
reviewed
Dec 9, 2024
| @@ -27,7 +27,8 @@ extension Glia { | |||
| hasPendingInteraction: { [weak self] in | |||
| guard let self else { return false } | |||
| return pendingInteraction.hasPendingInteraction | |||
| } | |||
| }, | |||
| currentInteractor: { self.interactor } | |||
There was a problem hiding this comment.
Does self here create retain cycle?
There was a problem hiding this comment.
fixed 88ccb46
|
|
||
| engagementCancellable = environment.currentInteractor()?.$currentEngagement | ||
| .sink { [weak self] engagement in | ||
| guard let self = self else { return } |
There was a problem hiding this comment.
Suggested change
| guard let self = self else { return } | |
| guard let self else { return } |
There was a problem hiding this comment.
fixed 88ccb46
| engagementCancellable = environment.currentInteractor()?.$currentEngagement | ||
| .sink { [weak self] engagement in | ||
| guard let self = self else { return } | ||
| self.ongoingEngagement = engagement |
There was a problem hiding this comment.
Suggested change
| self.ongoingEngagement = engagement | |
| ongoingEngagement = engagement |
There was a problem hiding this comment.
fixed 88ccb46
EgorovEI
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
76c87b1 to
c57e113
Compare
EgorovEI
force-pushed
the
Handle-ongoing-engagement-in-EntryWidget
branch
2 times, most recently
from
1648c85 to
65db29f
Compare
EgorovEI
approved these changes
Dec 13, 2024
igorkravchenko
approved these changes
Dec 13, 2024
|
!squash |
This PR handles ongoing engagement in EntryWidget for both core engagements and call visualizer. MOB-3806
sm-deployer
force-pushed
the
Handle-ongoing-engagement-in-EntryWidget
branch
from
65db29f to
29ceec9
Compare
rasmustautsglia
merged commit c735b3e
into
feature/entry-widget-and-secure-conversations-v2
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was solved?
This PR handles ongoing engagement in EntryWidget for both core engagements and call visualizer.
MOB-3806
Release notes:
Additional info:
Screenshots: