Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate pending interaction logic in separate model #1137

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Isolate pending interaction logic in separate model #1137

merged 1 commit into from
Dec 3, 2024

Conversation

igorkravchenko
Copy link
Contributor

MOB-3850

What was solved?
Introduce 'PendingInteraction' model to determine pending interaction for SC 2.0.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

ykyivskyi-gl
ykyivskyi-gl approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ykyivskyi-gl ykyivskyi-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Left minor comment

GliaWidgets/SecureConversations/SecureConversations.PendingInteraction.swift Outdated

extension SecureConversations {
final class PendingInteraction: ObservableObject {
private(set) var cancellables: Set<AnyCancellable> = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There as "sugar" typealias CancelBag, let's decide whether to use or remove it at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that one is not used at all 🤦‍♂️
Removed it altogether c4efd3c.

@igorkravchenko
Copy link
Contributor Author

!squash

@igorkravchenko igorkravchenko force-pushed the task/MOB-3850-pending-sc-single-request branch from 1e8962c to 878c293 Compare December 3, 2024 12:40
@igorkravchenko
Isolate pending interaction logic in separate model
f912444 
Introduce 'PendingInteraction' model to determine pending interaction for SC 2.0.

MOB-3850
@igorkravchenko igorkravchenko force-pushed the task/MOB-3850-pending-sc-single-request branch from 878c293 to f912444 Compare December 3, 2024 12:51
@igorkravchenko igorkravchenko merged commit 23f79d4 into feature/entry-widget-and-secure-conversations-v2 Dec 3, 2024
8 checks passed
@igorkravchenko igorkravchenko deleted the task/MOB-3850-pending-sc-single-request branch December 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykyivskyi-gl ykyivskyi-gl ykyivskyi-gl approved these changes

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorkravchenko @EgorovEI @rasmustautsglia @ykyivskyi-gl