Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot tests for bottom banner #1125

Conversation

igorkravchenko
Copy link
Contributor

MOB-3718

What was solved?
Add bottom banner snapshot tests and update bottom banner and send message unavailable banner to take safe are guide into account.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

Copy link
Contributor

@EgorovEI EgorovEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linter warnings in changed files

@igorkravchenko
Copy link
Contributor Author

!squash

Add bottom banner snapshot tests and update bottom banner and send message unavailable banner to take safe are guide into account.

MOB-3718
@sm-deployer sm-deployer force-pushed the task/MOB-3718-bottom-banner-snapshots branch from 58559ee to 14464af Compare November 20, 2024 11:45
@igorkravchenko igorkravchenko merged commit 7feecd8 into feature/entry-widget-and-secure-conversations-v2 Nov 20, 2024
8 checks passed
@igorkravchenko igorkravchenko deleted the task/MOB-3718-bottom-banner-snapshots branch November 20, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants