fixup! Connecting state issue fixes

Revert strong engagement refs back MOB-2730
salemove · Oct 12, 2023 · 6425083 · 6425083
1 parent 78755e5
commit 6425083
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/GliaWidgets/Sources/Interactor/Interactor.swift b/GliaWidgets/Sources/Interactor/Interactor.swift
@@ -56,7 +56,7 @@ class Interactor {
     }
 
     let configuration: Configuration
-    weak var currentEngagement: CoreSdkClient.Engagement?
+    var currentEngagement: CoreSdkClient.Engagement?
 
     /// Flag indicating if configuration was already performed.
     var isConfigurationPerformed: Bool = false

diff --git a/GliaWidgets/Sources/ViewModel/EngagementViewModel.swift b/GliaWidgets/Sources/ViewModel/EngagementViewModel.swift
@@ -11,7 +11,9 @@ class EngagementViewModel: CommonEngagementModel {
     let alertConfiguration: AlertConfiguration
     let environment: Environment
     let screenShareHandler: ScreenShareHandler
-    weak var activeEngagement: CoreSdkClient.Engagement?
+    // Need to keep strong reference of `activeEngagement`,
+    // to be able to fetch survey after ending engagement
+    var activeEngagement: CoreSdkClient.Engagement?
 
     private(set) var isViewActive = ObservableValue<Bool>(with: false)
 
@@ -34,6 +36,7 @@ class EngagementViewModel: CommonEngagementModel {
     }
 
     deinit {
+        print("☠️", Self.self, ObjectIdentifier(self))
         interactor.removeObserver(self)
         screenShareHandler.status().removeObserver(self)
         screenShareHandler.cleanUp()