Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO NEED TO REVIEW NOW] Feature/entry widget and secure conversations v2 #1133

Draft
wants to merge 102 commits into
base: development
Choose a base branch
from
Draft

[NO NEED TO REVIEW NOW] Feature/entry widget and secure conversations v2 #1133

wants to merge 102 commits into from

Conversation

andrews-moc
Copy link
Contributor

Jira issue:
https://glia.atlassian.net/browse/MOB-xxx

What was solved?

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@DavDo DavDo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 8ae0b3e to c866c9d Compare November 1, 2024 11:12
@DavDo DavDo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from d5f11d7 to 4482f85 Compare November 18, 2024 21:27
DavDo and others added 28 commits November 27, 2024 12:46
@DavDo @andrews-moc
Refactor configurations
b67ed27 
- Migrate Call and Chat Activities to Kotlin
- Refactor CallConfiguration
- Refactor EngagementConfiguration

MOB 3587
@DavDo @andrews-moc
Separate Intent-related functionality
a4d0aa1 
- Moved all the Intent-related functionality to the IntentHelper class.
- Abstraction will let us to easily mock this layer.

MOB 3582
@AndriiHorishniiMOC @andrews-moc
Implement Entry Widget (embedded view)
92afbc7 
MOB-3478
@AndriiHorishniiMOC @andrews-moc
Implement Entry Widget (bottom sheet)
59276cd 
MOB-3476
@DavDo @andrews-moc
Create new internal layer responsible for opening screens
784f646 
- Create ActivityLauncher
- Rename FilePreview... classes to ImagePreview...

MOB 3589
@AndriiHorishniiMOC @andrews-moc
Unified UI customization for Entry Widget and SCv2
c223631 
MOB-3591
@DavDo @andrews-moc
Devs want to create public interfaces for EngagementLauncher
e2d5c7f 
- Create interfaces for EngagementLauncher
- Create basic ConfigurationManager that should hold all the init config

MOB 3588
@DavDo @andrews-moc
Rename all the Unified UI related classes to new SecureMessaging... way
e69e2f2
@gugalo @andrews-moc
Add support of glia custom attributes to Entry Widgets
1062bb3 
This custom attributes can be setup by integrators in their theme.xml
@gugalo @andrews-moc
Change colors in layout xml's to use custom attr
f5a473c 
This is needed so that customise glia theme settings in integrators theme.xml
@DavDo @andrews-moc
Implement EngagementLauncher business logic
d865315 
- Remove all the configurations in favor of ConfigurationManager
- Get rid of configurations passed through Activity extras
- Move extra keys to internal class
- Make activities internal
- Minor refactoring
@andrews-moc
Devs want to implement the logic for showing available engagement types
4db7619 
MOB-3411
@gugalo @andrews-moc
Update Entry Widget texts
5b752a1 
Texts have changed, updating according to the Figma designs.

MOB-3615
@gugalo @andrews-moc
Remove deprecated functions which are older than 1 year
f3f9d55 
MOB-2889
@DavDo @andrews-moc
Add gliaBrandPrimaryColor tint to entry widget icon tint.
d562cfc
@andrews-moc
Send error event if Glia is not initialized before getting an Entry W…
b6feeaa 
…idget

Setup queues each time get Entry Widget is called

MOB-3408
@AndriiHorishniiMOC @andrews-moc
Enable scrolling for the Entry Widget bottom sheet.
8af0602 
MOB-3642
@DavDo @andrews-moc
Cache site queues after first request
2d5f04f 
MOB 3620
@andrews-moc
Change 'Try again' button style for Entry Widget error state accordin…
36dc4d3 
…g to design

MOB-3478
@DavDo @andrews-moc
Devs want to use cached Queues to check Secure Messaging availability
e393e26 
MOB 3646
@AndriiHorishniiMOC @andrews-moc
Added snapshot tests for the Entry Widget
19742dc 
MOB-3544
@andrews-moc
Pass null instead of an empty list if "Default Queues" toggle is enab…
45e1cbd 
…led in Example App settings

MOB-3657
@andrews-moc
Hide 'Secure Messaging' engagement type from Entry Widget if visitor …
ad37045 
…is not authenticated

MOB-3659
@andrews-moc
Make queueIds list non-nullable, so only empty list means that defaul…
3f87f1a 
…t queues should be used

MOB-3657
@DavDo @andrews-moc
Devs want to make UiTheme internal
7bcab02 
MOB 3667
@AndriiHorishniiMOC @andrews-moc
Added loading tint color customization
0d8fed0 
MOB-3591
@gugalo @andrews-moc
Update Kotlin version
77de6f0 
This change is directly related to changes in Core SDK regarding OkHttp version.
See salemove/android-sdk#763

MOB-3661
@DavDo @andrews-moc
Devs want to always fallback to default queues
b844485 
MOB 3673
DavDo and others added 10 commits November 27, 2024 12:54
@DavDo @andrews-moc
Resolve merge conflicts
2e488d2
@DavDo @andrews-moc
Fix Chat screen is opened incorrectly from Call screen
098e8ff
@andrews-moc
Refresh Entry Widget on Glia init
8670d11 
Scenario:
- show embedded view before Glia is initialized (error state is shown)
- init Glia
- expected result: error state is replaced with loading state and data state afterwards

MOB-3810
@andrews-moc
Adjust Entry Widget UI based on designer review
4345339 
- Adjust font for engagement type title and description
- Adjust bottom margin for "Powered by" and align it with the Glia logo baseline
- Adjust letter spacing

MOB-3754
@DavDo @andrews-moc
Use subscriptions for unread messages and pending secure conversations
9552f4d
@gugalo @andrews-moc
Update Core SDK staging repo url
2c96f74 
The old staging version of Core SDK got automatically deleted for some reason.

Discussion in slack:
https://salemove.slack.com/archives/C01F9K88SQZ/p1732545132319779?thread_ts=1732527166.629109&cid=C01F9K88SQZ
@gugalo @andrews-moc
Add 'Need Live Support?' banner to SC chat
8ce307b 
MOB-3639
@DavDo @andrews-moc
Devs want to implement GVA(Live engagement) to SC transfer
ffe9885
@andrews-moc
Update snapshot tests after rebase
35c246c 
MOB-3807
@andrews-moc
Update Core SDK staging repo URL
7083628
@andrews-moc andrews-moc force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 420a67a to 7083628 Compare November 27, 2024 12:54
gugalo and others added 11 commits November 28, 2024 10:32
@gugalo
Fix RX timeout issue
1034e8f 
In some places the Observable#timeout() had unwanted results. Specifically:
- It terminated observable breaking delivery of events after the timeout triggered
- Plan was for it to fire timeout exception only if there was no previous event but it also triggered even when there was valid values.

MOB-3839
@andrews-moc
Prevent recursive dismiss() call
8fe6c4d 
MOB-3845
@DavDo
Consider the ongoing sc when checking for secure messaging availability
e19999d
@DavDo
Fix Entry Widget watermark visibility is not configurable
f776415
@DavDo
Remove the timeout from SC properties
2d6ebd2
@DavDo
Devs want to handle SC chat top banner item click
acdb98f
@DavDo
Refactor SC logic to make switching between Live and SC seamless
45c9ea8
@andrews-moc
Add snapshot tests for Entry Widget for the cases when 'whiteLabel ==…
9f0c19b 
… true'

MOB-3854
@gugalo
Fix send and attachment buttons overlap
67c75b9 
Side effect of making the layout flat is that now those buttons have slight animation.

MOB-3844
@gugalo
Add snapshot tests for SC top banner
93ed0a8 
MOB-3639
@gugalo
Update staging build link
193bd13 
Last Core SDK staging build got expired/deleted so uploaded new build
@gugalo gugalo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from c10901b to 193bd13 Compare December 12, 2024 12:21
@gugalo
Implement Leave Current Conversation dialog
bbf1c40 
MOB-3637
@gugalo
Add disabled color state for chat input
71de68b 
- Added inputDisabled Json to UI remote theme configurations
- Switched simple color/drawables to ColorStateList/DrawableStateList

MOB-3855
@gugalo
Fix jumpy animation of chat input on keyboard show/hide
c55758d 
MOB-3860
@gugalo gugalo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 2741376 to c55758d Compare December 13, 2024 13:01
AndriiHorishniiMOC and others added 3 commits December 16, 2024 11:45
@AndriiHorishniiMOC @gugalo
Refactor file attachment repositories
057d576 
Remove SecureFileAttachmentRepository and some SC use cases that duplicated the logic.
Refactor FileAttachmentRepository and the file upload use cases. FileAttachmentRepository is used for both SC and Live Engagement.

MOB-3791
@gugalo
Fix grapish color for disabled input
bd938d5 
Issue introduced in #1183
@andrews-moc
Update staging build link
ed696c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrews-moc @DavDo @AndriiHorishniiMOC @gugalo