Skip to content

Commit

Permalink
Revert reduction in message check frequency in packet processing threads
Browse files Browse the repository at this point in the history
Unfortunately, if we don't check before processing every packet
then we run the risk of failing to intercept the RTP at the
very start of a voice call.
  • Loading branch information
salcock committed Dec 19, 2024
1 parent 6f4889f commit 9a9943c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions debian/changelog
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ openli (1.1.11-1) unstable; urgency=medium
threads. Standalone SMS interception threads now no longer exist.
* Collector: add configuration option to specify a coremap for an
individual input.
* Collector: decreased frequency at which packet processing threads will
check for incoming messages from session tracking threads.
* Collector: improved packet processing thread performance by avoiding
fragment offset calculations if the packet is clearly not a fragment.
* Collector: improved encoding performance by pre-encoding certain
Expand Down
2 changes: 0 additions & 2 deletions src/collector/collector.c
Original file line number Diff line number Diff line change
Expand Up @@ -926,9 +926,7 @@ static libtrace_packet_t *process_packet(libtrace_t *trace,

packet_info_t pinfo;

if (loc->pkts_since_msg_read >= PACKETS_PER_READ_THRESH) {
check_for_messages(loc);
}

loc->pkts_since_msg_read ++;
l3 = trace_get_layer3(pkt, &ethertype, &rem);
Expand Down

0 comments on commit 9a9943c

Please sign in to comment.