SAK-50675 portal remove widgets from profile sidebar #13012
+2
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfish
force-pushed
the
SAK-50675
branch
2 times, most recently
from
6e2988b
to
b7e6ca5
Compare
ern
changed the title
| @@ -58,18 +45,17 @@ | |||
| "format" : [#foreach( $format in $mathJaxFormat )"${format}",#end] | |||
| }, | |||
| toolTitles : {#foreach ($entry in $toolTitles.entrySet())"$entry.key": "$entry.value",#end}, | |||
| notifications: { pushEnabled: $!notificationsPushEnabled, debug: $!debugNotifications }, | |||
There was a problem hiding this comment.
Think those 2 variables are referenced at SkinnableCharonPortal and nowhere else, they could be removed too?
|
Waiting for T&L to respond in this removal |
adrianfish
force-pushed
the
SAK-50675
branch
2 times, most recently
from
b967bf3
to
15ab361
Compare
| @@ -1029,8 +1027,6 @@ public PortalRenderContext startPageContext(String siteType, String title, Strin | |||
|
|
|||
| rcontext.put("notificationsPushEnabled", notificationsPushEnabled); | |||
There was a problem hiding this comment.
I think this one is still left
Plus a couple properties:
- portal.title.shortdescription.show
- portal.notifications.push.enabled
There was a problem hiding this comment.
push.enabled needs to stay because the user messaging service uses it.
There was a problem hiding this comment.
True, I thought it wasn't used anywhere else
adrianfish
force-pushed
the
SAK-50675
branch
from
7f45bd0
to
8e3408b
Compare
adrianfish
force-pushed
the
SAK-50675
branch
from
8e3408b
to
67b0b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50675