SAK-40229 Content screen reader announcing file upload to dropbox #12995
Conversation
content/content-tool/tool/src/webapp/vm/resources/sakai_dropbox_multiple_folders_upload.vm
Outdated
Show resolved
Hide resolved
content/content-tool/tool/src/webapp/vm/resources/sakai_dropbox_multiple_folders_upload.vm
Outdated
Show resolved
Hide resolved
content/content-tool/tool/src/webapp/vm/resources/sakai_dropbox_multiple_folders_upload.vm
Outdated
Show resolved
Hide resolved
content/content-tool/tool/src/webapp/vm/resources/sakai_dropbox_multiple_folders_upload.vm
Outdated
Show resolved
Hide resolved
| else | ||
| { | ||
| feedback.classList.add('d-none'); | ||
| nameField.value = ''; | ||
| } |
There was a problem hiding this comment.
Do we need else block ? when there's no file selected nothing changes and d-none is already present.
There was a problem hiding this comment.
I checked that when I deselect a file, the message and display name do not disappear. That's why I added the else block and it works as intended.
There was a problem hiding this comment.
@kunaljaykam can you please review this and let me know if any changes are required?
There was a problem hiding this comment.
You are correct. I tested your pr. The else block is necessary to clear outdated file info when the file picker is opened but no new file is selected. Without it, the old file name and feedback message remain and causes console error.
I think we should re-write the whole handleFileChange function it looks messy, and include the display name field inside; fileField.files.length > 0) check as well so display name gets updates as well.
content/content-tool/tool/src/webapp/vm/resources/sakai_dropbox_multiple_folders_upload.vm
Outdated
Show resolved
Hide resolved
| nameField.value = fileField.files[0].name; | ||
| } | ||
| previousFileName = fileField.files[0].name; | ||
| ## Goal: update the display name field. But if the user provided their own display name, don't overwrite it |
No description provided.