-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PatchmanagerPage: Reorder pulley menu entries #272
Conversation
… "Settings" shall be below "About" and easier to reach, plus "Deactivate all Patches" the hardest to reach (i.e., topmost)
I revisited this topic (literally, i.e., by looking at it closely in its current state) and the order just appears to be awkward: Why is the "Settings" entry above the "About" entry, which is much less often used; and why are they both above the dangerous "Deactivate all Patches" entry? Hence I "just did it": Reordered the topmost three entries so it does make sense (to me, at least). |
I disagree with you there. In my experience, top menu entries are easiest to reach by acccident (maybe tied with the first/lowest entry when you somehow lose touch). About the general Pulley menu order, it's very common for in the SFOS app space to have About at the top, Settings next, and all others below those. We should follow that layout. |
Yes! Luckily we have converging opinions here (with issue #20 as a starting point), because I always perceived it as very awkward that Patchmanager has "Settings" as the topmost entry and "About" directly below it. So the only point left where we do still not concur is the position of the "Deactivate all Patches" entry.
Thus I am seriously asking either to "hide" this "dangerous" pulley menu entry where it does least harm (which is the topmost entry IMO) or to eliminate it (which likely is the proper solution). |
I have no objections to removing it competely, or add and option to show/hide it in the "Advanced" Settings. Although I do find it useful sometimes and will problably patch it back in privately it it's removed ;) About failure/panic mode: I haven't looked into it, but I think that is activated whenever lipstick crashes for any reason. I would expect it to restore the configuration that was last saved*), of at least give to option to do that. But these things are something to be discussed in a separate issue, not here. (#277, #278) *) flashbacks of Windows last good configuration |
I guess for this PR we have an agreement that reordering the Settings/About is what we'll do. Please make a push doing that, and if you like comment out the "unapply all" Menu entry. If you do I will implement the Settings part on top later. |
… pulley menu entry.
Commit e140cfd disables the "Deactivate all Patches" pulley menu entry. Please check that I have done that correctly, I have to look up the f**king QML syntax even for such simple things. |
* fixup! PatchmanagerPage: Reorder pulley menu entries (#272) * Control Unapply All option through settings * update Requires for Nemo.Configuration plugin * fixup! Control Unapply All option through settings * PatchManagerPage: Enhance comment * SettingsPage: Enhance commment and new strings * SettingsPage: Hope that "for" is a correct preposition … after trying "at" and pondering about "on" (both "feel" plausible, but not like a perfect fit). Co-authored-by: olf <[email protected]>
otherwise the view.busy is undefined. This had previously been handled differently but was overlookedin the changes about unapply all. See 573ce87 for the original handling, and PR sailfishos-patches#272.
… "Settings" shall be below "About" and easier to reach, plus "Deactivate all Patches" the hardest to reach (i.e., topmost)