-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow saving and loading activation state #277
Comments
That would be really cool, I considered to document that multiple times in the last five years. I did refrain from doing so, because it believe it is not easy to implement: The user may have uninstalled, updated or installed new Patches since writing that list. I see two basic approaches:
IMO approach 1 is much more usable, but might be harder to implement. |
The list of currently active patches is already saved in the config file and updated when anything about activation state changes. See the What remains is to improve the "go out of failure state" actions to restore state correctly, and the option to restore the state from that list on demand (i.e. after unapply all). |
This is what I also realised after thinking about it: The "applied" state must already be stored somewhere.
👍 |
commit 9627714 Merge: 50d3293 e74cf3e Author: nephros <nemo@pgxperiiia10> Date: Tue Jun 13 23:54:10 2023 +0200 Merge branch 'master' into recover-failures commit 50d3293 Author: nephros <nemo@pgxperiiia10> Date: Thu Jun 1 08:29:02 2023 +0200 [tool]: fix syntax commit ac9b31c Merge: d24ee1e 3974d0f Author: nephros <nemo@pgxperiiia10> Date: Thu Jun 1 08:25:36 2023 +0200 Merge branch 'recover-failures' of git+ssh://github.com/nephros/patchmanager into recover-failures commit 3974d0f Merge: 7c6611a ae85a89 Author: Peter G <[email protected]> Date: Tue May 30 05:16:55 2023 +0000 Merge branch 'master' into recover-failures commit d24ee1e Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:24:40 2023 +0200 refresh after setting good list commit 0fe5d47 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:24:11 2023 +0200 only set good patches if we have any commit 7c6611a Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:14:47 2023 +0200 [trivial] whitespace-align help output commit a73a4fc Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:14:20 2023 +0200 Add "load known-good" to command line options commit 3acc095 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 10:37:34 2023 +0200 fixup! Add call to save current set as KnownGood commit adaed74 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 10:27:46 2023 +0200 Add "save as good" to command line options commit 9c1f07d Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 10:19:18 2023 +0200 Add call to save current set as KnownGood commit 2b04ab6 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 09:40:44 2023 +0200 Add option to load last-know-good patch list Contributes-To: sailfishos-patches#277 commit 777d43d Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 09:23:28 2023 +0200 if auto applying succeded, save a known good state
commit 9627714 Merge: 50d3293 e74cf3e Author: nephros <nemo@pgxperiiia10> Date: Tue Jun 13 23:54:10 2023 +0200 Merge branch 'master' into recover-failures commit 50d3293 Author: nephros <nemo@pgxperiiia10> Date: Thu Jun 1 08:29:02 2023 +0200 [tool]: fix syntax commit ac9b31c Merge: d24ee1e 3974d0f Author: nephros <nemo@pgxperiiia10> Date: Thu Jun 1 08:25:36 2023 +0200 Merge branch 'recover-failures' of git+ssh://github.com/nephros/patchmanager into recover-failures commit 3974d0f Merge: 7c6611a ae85a89 Author: Peter G <[email protected]> Date: Tue May 30 05:16:55 2023 +0000 Merge branch 'master' into recover-failures commit d24ee1e Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:24:40 2023 +0200 refresh after setting good list commit 0fe5d47 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:24:11 2023 +0200 only set good patches if we have any commit 7c6611a Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:14:47 2023 +0200 [trivial] whitespace-align help output commit a73a4fc Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 12:14:20 2023 +0200 Add "load known-good" to command line options commit 3acc095 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 10:37:34 2023 +0200 fixup! Add call to save current set as KnownGood commit adaed74 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 10:27:46 2023 +0200 Add "save as good" to command line options commit 9c1f07d Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 10:19:18 2023 +0200 Add call to save current set as KnownGood commit 2b04ab6 Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 09:40:44 2023 +0200 Add option to load last-know-good patch list Contributes-To: sailfishos-patches#277 commit 777d43d Author: nephros <nemo@pgxperiiia10> Date: Fri May 26 09:23:28 2023 +0200 if auto applying succeded, save a known good state
* If auto applying succeded, save a known good state * Add option to load last-know-good patch list * Add call to save current set as KnownGood * Add "save as good" to command line options * Add "load known-good" to command line options Contributes-To: #277 --------- Co-authored-by: nephros <nemo@pgxperiiia10> Co-authored-by: olf <[email protected]>
See also #272 (comment)
For users who have a lot of patches it would be useful to have the option to restore a certain configuration of active patches.
So one can get out of failure mode quickly and with minimal hassle, and just in general.
For the first iteration I think saving a single configuration is enough, managing a list of favorite combinations is not necessary.
The text was updated successfully, but these errors were encountered: