Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping the remorse timer should cancel activating patches only temporarily (for that single boot), not DISABLE all patches permanently #321

Open
wetab73 opened this issue Oct 3, 2022 · 1 comment
Labels
feature request feature requests, suggestions, ideas etc.

Comments

@wetab73
Copy link

wetab73 commented Oct 3, 2022

If one turns off the option to "Activate patches when booting", a remorse timer is shown upon boot and tapping it allows cancelling activation of enabled patches. So far so good.

The problem is that instead of temporarily cancelling activation of patches (on that specific boot only), after tapping that remorse timer Patchmanager DISABLES all patches FOR GOOD. All patches get PERMANENTLY DISABLED and nothing gets started upon the next reboot (even though the remorse timer is again shown to allegedly stop activating patches). It takes manually re-enabling all patches from scratch.

Tapping the remorse timer should cancel activation of patches only temporarily (i.e. for that boot only). Upon the next reboot, Patchmanager should activate them again, unless the remorse timer is tapped again to prevent it.

@wetab73 wetab73 added the feature request feature requests, suggestions, ideas etc. label Oct 3, 2022
@wetab73 wetab73 changed the title Tapping the remorse timer should cancel activating patches temporarily (for that boot only), not DISABLE all patches for good Tapping the remorse timer should cancel activating patches only temporarily (for that single boot), not DISABLE all patches permanently Oct 3, 2022
@nephros
Copy link
Contributor

nephros commented Oct 4, 2022

Currently PM only knows two states of patches that are stored persistently: activated and deactivated.

When the startup UI runs, it then can either apply the stored settings (activate all enabled patches), or not do that, which causes all to be not activated.

This feature would require a third state, enabled-but-not-activated to be set by the startup UI and interpreted by the daemon.

Maybe #277 and #302 can improve the situation after tapping cancel when they have been finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature requests, suggestions, ideas etc.
Projects
None yet
Development

No branches or pull requests

2 participants