Skip to content

Commit

Permalink
Pin Gloo repository in JAX Dockerfile to a specific commit (kubeflow#…
Browse files Browse the repository at this point in the history
…2329)

This commit pins the Gloo repository to a specific commit (43b7acbf) in
the JAX Dockerfile to prevent build failures caused by a recent bug
introduced in the Gloo codebase. By locking the version of Gloo to
a known working commit, we ensure that the JAX build remains stable and
functional until the issue is resolved upstream.

The build failure occurs when compiling the gloo/transport/tcp/buffer.cc
file due to an undefined __NR_gettid constant, which was introduced
after the pinned commit. By using this commit, we bypass the issue and
allow the build to complete successfully.

Signed-off-by: Sandipan Panda <[email protected]>
Signed-off-by: sailesh duddupudi <[email protected]>
  • Loading branch information
sandipanpanda authored and saileshd1402 committed Dec 2, 2024
1 parent cc0ef4d commit 3f5c458
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions examples/jax/cpu-demo/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ RUN apt-get update && apt-get install -y \

RUN git clone https://github.com/facebookincubator/gloo.git \
&& cd gloo \
&& git checkout 43b7acbf372cdce14075f3526e39153b7e433b53 \
&& mkdir build \
&& cd build \
&& cmake ../ \
Expand Down

0 comments on commit 3f5c458

Please sign in to comment.