Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve console clear screen performance #618

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Improve console clear screen performance #618

merged 2 commits into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. core: use blocking writes for TTYs 

    Like Node does.
    @saghul
    saghul committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6c2dc36 View commit details
    Browse the repository at this point in the history

  2. console: don't reset the terminal con console.clear() 

    It has side-effects: https://stackoverflow.com/a/37778152

The new implementation follows Node, that is, it moves the cursor home
and then it clears the screen down from there.

IN addition, avoid doing any of this if the terminal is dumb.
    @saghul
    saghul committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    485759a View commit details
    Browse the repository at this point in the history