Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint and add lint aciton #13

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

faddat
Copy link

@faddat faddat commented May 21, 2024

  • lint

@faddat faddat marked this pull request as draft May 21, 2024 05:54
@luckychess
Copy link
Contributor

Hey @faddat,

Thanks for your contribution and sorry for the late response. The overall idea of your pull request looks great but could you please polish it a bit:

  • Let's limit this PR's scope to linter and discuss version updates in your second PR thread
  • Please pull the latest main and resolve conflicts
  • It will be better to apply linter to all branches

When everything is fixed, I see no issues why not to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants