-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added infinite-ish scroll feature #17
Conversation
Thanks for the effort @AustinLeeGordon nicely done !
I still think we should copy the items and only render the visible ones (
This is also necessary for lazy loading which i also want to support (though it is achievable in user land as well) What are your thoughts? |
@sag1v Agreed. I looked at some other carousels with infinite scroll and this seems to be the best way to do it. |
@AustinLeeGordon Is there any infinite loop carousel demo? There is no infinite section in doc. I write infinite={true} in the Carousel but not working. |
@Anu-Ujin There is no infinite section in demos because its not supported yet. |
How can I add an infinite loop section for react-elastic-carousel, please help me |
How to loop using this? the buttons are getting disabled everytime on reaching the last element. edit: solution is (disableArrowsOnEnd={false}) |
Implemented an infinite scroll option as mentioned in #9
@sag1v I know you mentioned adding copies to make it actually appear to be infinite, but I think this is a good start for now for anyone who wants to use it as is. I personally don't mind the backwards scroll.
Seems like creating copies would be very inefficient, but I don't see a way to easily get around that.
Since it's not truly infinite, it will stop on the first/last item when it has potential to scroll past it. Here's an example:
I had issues trying to put together a demo page, so I left that mess out, but I did test it out on the current demos.
Let me know what you think!