Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added seed file for bid_status_histories #61

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ikezuby2012
Copy link

Pull Request for SafeTrust - Close Issue

❗ Pull Request Information

feat: added seed file for bid_status_histories table at seeds/safetrust folder
Add here some information

πŸŒ€ Summary of Changes

  • Add here the changes:
  • Changes just made to seeds/safetrust (new features)
  • More changes:

πŸ›  Testing

NOT NEEDED!

Evidence Before Solution

Evidence After Solution

πŸ“‚ Related Issue

This pull request will close # [Issue Number] upon merging.

This Pull request will close #53 upon merging

πŸŽ‰ Thank you for reviewing this PR! πŸŽ‰

@sotoJ24 sotoJ24 requested review from sotoJ24 and removed request for sotoJ24 December 17, 2024 20:06
(uuid_generate_v4(), (SELECT id FROM bid_requests LIMIT 1 OFFSET 0),, 'Submitted', 'Bid request has been submitted.', (SELECT id FROM users WHERE username = 'user'), NOW()),
(uuid_generate_v4(), (SELECT id FROM bid_requests LIMIT 1 OFFSET 1), 'Reviewed', 'Initial review completed by team lead.', (SELECT id FROM users WHERE username = 'team-lead'), NOW() - INTERVAL '1 day'),
(uuid_generate_v4(), (SELECT id FROM bid_requests LIMIT 1 OFFSET 2), 'Approved', 'Bid request approved by manager.', (SELECT id FROM users WHERE username = 'manager'), NOW() - INTERVAL '2 days'),
(uuid_generate_v4(), (SELECT id FROM bid_requests LIMIT 1 OFFSET 3), 'In_Progress', 'Work on the bid has commenced.', (SELECT id FROM users WHERE username = 'user'), NOW() - INTERVAL '3 days'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase this as:

'Work on the bid has begun.'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

package.json Outdated
Comment on lines 21 to 28
"backend": "file:",
"cucumber-html-reporter": "^5.5.0",
"dotenv": "^16.4.5",
"express": "^4.21.1",
"express-rate-limit": "^7.4.1",
"graphql-request": "^7.1.2",
"nodemailer": "^6.9.16",
"winston": "^3.17.0",
"cucumber-html-reporter": "^5.5.0"
"winston": "^3.17.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo these changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please review changes

@ikezuby2012
Copy link
Author

Done with the changes

@sotoJ24
Copy link
Contributor

sotoJ24 commented Dec 19, 2024

Done with the changes

Thank you @ikezuby2012

sotoJ24
sotoJ24 previously approved these changes Dec 20, 2024
Copy link
Contributor

@sotoJ24 sotoJ24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @ikezuby2012, the package-lock.json is still modified, can you please undo that's changes, btw we need almost 20 rows to test the pagination, thanks and regards

Screenshot 2024-12-20 195034

@sotoJ24 sotoJ24 self-requested a review December 21, 2024 01:57
Copy link
Contributor

@sotoJ24 sotoJ24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, keep us updated about the request changes

@ikezuby2012
Copy link
Author

done, please review

Copy link
Contributor

@sotoJ24 sotoJ24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dear @ikezuby2012 hope you're doing well

we noticed that when the query is executed, throwing an error: "message": "column \"username\" does not exist"

Screenshot 2024-12-30 191309

The username column must be replaced with the email column for it to work.

Whatever you need just let Us know, thanks

@ikezuby2012
Copy link
Author

Please review

Copy link
Contributor

@sotoJ24 sotoJ24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ikezuby2012, it still doesn't work, because the email table does not exist
Screenshot 2024-12-31 160553

could you make the query something like this:

INSERT INTO bid_status_histories (id, bid_request_id, status, notes, changed_by, created_at) VALUES (uuid_generate_v4(), (SELECT id FROM bid_requests LIMIT 1 OFFSET 0), 'Submitted', 'Bid request has been submitted.', (SELECT id FROM users LIMIT 1 OFFSET 0), NOW()),

and the following,
Regards

@ikezuby2012
Copy link
Author

check now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed script for bid_status_histories table🌱
3 participants