Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Update twap tests #4590

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Tests: Update twap tests #4590

merged 1 commit into from
Dec 2, 2024

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Dec 2, 2024

What it solves

How this PR fixes it

  • Some TWAP tests were previously failing due to inconsistent behavior, as detailed here. Upon revisiting the issue, it became evident that the app's state had improved, and the bug was no longer reproducible. However, updates to the tests were necessary to restore functionality, including adjustments to the steps and UI locators.

How to test it

  • Run Cypress tests and observe outcome.

Copy link

github-actions bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Dec 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 73.66% 14335/19462
🔴 Branches 51.8% 3515/6786
🔴 Functions 57.08% 2081/3646
🟡 Lines 75.25% 13025/17309

Test suite run success

1661 tests passing in 226 suites.

Report generated by 🧪jest coverage report action from aa910b1

@mike10ca mike10ca merged commit b30a74b into dev Dec 2, 2024
15 checks passed
@mike10ca mike10ca deleted the update-twap-tests branch December 2, 2024 15:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants