Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.48.0 #4588

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

Release 1.48.0 #4588

wants to merge 48 commits into from

Conversation

katspaugh
Copy link
Member

Features

Refactoring

Bug fixes

Chores

Tests

compojoom and others added 30 commits November 19, 2024 11:09
* chore: update to nextjs 15

* chore: fix tsc lint errors

* chore: fix eslint errors

* chore: fixing failing unit tests

* chore: remove yarn

* chore: update eslint to v9

* chore: update github eslint action

* chore: update cypress to v13.15.2 (#4490)

* chore: update cypress to v13.15.2

* chore: update cypress github action to use v13.15.2

* chore: update mui to v6 (#4499)

* chore: update mui to v6

Applied codemons to update the code

* refactor: fix DatePicker with mui v6

fix: failing Date test

* refactor: use ListItemButton instead of ListItem

the selected and disabled props on ListItem have been removed in v6, but
are available on the ListItemButton

* chore: update snapshots

* refactor: recoveryModal tests use snapshots

* fix: failing bookmarks test with mui v6

* fix: missing DM-Sans font

* fix: drawer was stealing clicks from rest of page

* fix: failing tests

* fix: fonts fail to load

Read the comment in the file and have fun!

* fix: prettier errors

* fix: tsc errors
* Fix: mui accordion background

* Update tests
* Fix: remove old app store button

* Rm import
* Chore: replace @WalletConnect packages with @reown/walletkit

* Fix tests

* Add core
* fix: fetch safe overviews including untrusted token fiatTotal

* test: fix safeOverviews.test.ts

* chore: add comment explaining why trusted needs to be false
Bumps [ethers](https://github.com/ethers-io/ethers.js) from 6.11.1 to 6.13.4.
- [Release notes](https://github.com/ethers-io/ethers.js/releases)
- [Changelog](https://github.com/ethers-io/ethers.js/blob/main/CHANGELOG.md)
- [Commits](ethers-io/ethers.js@v6.11.1...v6.13.4)

---
updated-dependencies:
- dependency-name: ethers
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Feat(Sidebar): Add pinned safes list to sidebar and accounts page [SW-304] (#4412)

* feat: allow pinning and unpinning accounts

* feat: allow pinning multichain safes

* fix: pinning of multichain safes

* feat: simplify all accounts list

* feat: load safe info when safelist item is scrolled into view

* feat: remove safes when unpinning if they werent added before being pinned

* fix: pinning behaviour of multichain safes

* fix: multichain sub itemstyles

* feat: add empty state for pinned list

* fix: lint errors

* fix: show threshold for counterfactual safes

* fix: mobile layout

* restore loading balances for safes

* fix: subaccount item layout, and app crashing on unpin

* feat: expand all accounts if there are no pinned safes

* fix: flickering when loading all safes

* fix: account for default threshold and owner numbers

* reduce transition animation duration for pinning and unpinning safes

* reduce space between chains and balance

* Feat(sidebar): sort safes by name and recently used [SW-307] (#4458)

* Feat: add option to sort by recently visited and by name

* tests: add new properties to unit tests

* fix: make order by preference persist

* feat: sort sub account items by name and recently visited

* refactor: fix incorrect variable names and remove console log

* Feat(sidebar): filter safes by search query [SW-305] (#4484)

* feat: filter safes by search query

* feat: display current order by option. fix text colors

* feat: search by adddress name and chain name

* fix: use ignoreLocation to match the final address characters when searching

* add tracking event for search

* fix: cypress tests

* Feat(sidebar): Add tracking events for search, sorting, and pinning/unpinning safes [SW-308] (#4500)

* track the number of pined safes on the accounts page

* feat: track pinning, unpinning, and sorting

* fix: separate watchlist and pined safes for tracking

* fix: remove wallet from dependency array

* Update src/components/welcome/MyAccounts/useTrackedSafesCount.ts

Co-authored-by: Usame Algan <[email protected]>

* fix: lint

---------

Co-authored-by: Usame Algan <[email protected]>

* Refactor(Sidebar): use feature directory structure for MyAccounts (#4508)

* refactor: move myAccounts to features

* fix:align  queue and status chips with address for large screens

* remove commented code

* fix: chip styles

* fix(sidebar):  fix designs for data widget and empty/disconnected state [SW-507] (#4509)

* fix: add connect wallet button and empty state

* fix: datawidget styles

* Fix(Sidebar): Include sub safe in search results [SW-305] (#4527)

* fix: CF chip dark mode color

* include multichain sub safe names in search

* fix: queue chips being cut off

* Fix: rm Remove option

* Refactor: pinned = added safes [SW-304] (#4552)

* Refactor: pinned = added safes

* Rm Watchlist word

* Fix duplicate cf safes

---------

Co-authored-by: Usame Algan <[email protected]>
Co-authored-by: katspaugh <[email protected]>
Co-authored-by: katspaugh <[email protected]>
* fix: Disable transaction buttons until sdk is initialized

* fix: Failing tests

* fix: Add test case and adjust other tests to use getByText

---------

Co-authored-by: katspaugh <[email protected]>
* Refactor: rm unnecessary tx decoding

* Update tests

* Repropose after sign relayed

* Update SDK type

* Update src/components/tx/confirmation-views/index.tsx

Co-authored-by: Usame Algan <[email protected]>

* Fix Order type

* Make 420 more random

---------

Co-authored-by: Usame Algan <[email protected]>
usame-algan and others added 14 commits November 28, 2024 14:32
* Add LI.FI widget

* Add theme parameter and fix redirect

* Add test coverage

* Add sanction handling and disclaimer

* Add new chip

* Simplify badge

* Remove redundant test

* Put sidebar item behind feature flag

* Fix lint

* Add geo-blocking

* Make sidebar item dependant on feature flag

* Display bridging before checking sanctions

* Fix test

* Add tracking and rename prop
- add a new recovery option for zkEmail
- proceeding with this new option selected will show a modal with some info as fake door
* feat: nested signer integration

* test: fix SignTxButton test

* feat: implement correct design

* refactor: use rtk query to load owners

* feat: new success screen for nested transactions

* refactor: move useNestedWallet to nested-safe-wallet util

* fix: design, make link external

* fix: signature indexed state for nested signing

* fix: first review issues

* fix: finish NestedTxSuccessScreen

* fix: only load ownedSafes of current chain for useNestedSafeOwners

* fix: move selected signer state into WalletProvider

* fix: error handling when signing nested tx

* refactor: extract re-used code into fields

* fix: tenderly simulation uses signer instead of wallet address, fix ExternalLinks

* fix: select available signer in SafeTxProvider, disable signers that already signed

* fix: working parent tx link for direct execution

* feat: add analytics events for nested signing

* fix: use signer address in blockaid scans

* fix: selecting initial available signer in tx modal

* test: useBlockaid.test.ts

* fix: Safe app readOnly state for nested ownership

* fix: executing txs as parent Safe

* fix: iterate signing methods for parent (hardware) wallets

* fix: only don't iterate signing of executions

* fix: use correct hash on success screen

* fix: take execution into account when selecting signer

* fix: cache pending transaction on parent creation screen

* fix: catch malformed `safeTxHash`

* fix: lint

* Improve tracking

* Add events

* Don't show status screen for singular owners

* Revert "Don't show status screen for singular owners"

This reverts commit a74606e.

* Navigate to queue if we don't have `safeTxHash`

* Fix lint

* Fix test

* Allow execution by any wallet and add transaction type to event

* Fix already signed signers being enabled

* Fix event

* Fix lint

* Address review comments

---------

Co-authored-by: Aaron Cook <[email protected]>
* Fix: replace "signer(s)" with "N signers" or "1 signer"

* maybePlural

* Use for remaining relays
* Add event labels to opening and (un-)pinning of Safe Apps

* Only prevent link from opening if never opened before
Copy link

github-actions bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Dec 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.66% (-0.67% 🔻)
14337/19464
🔴 Branches
51.8% (-0.88% 🔻)
3515/6786
🔴 Functions
57.08% (-1.02% 🔻)
2081/3646
🟡 Lines
75.25% (-0.7% 🔻)
13027/17311
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / version.ts
75% 100% 100% 100%
🟡
... / visitedSafesSlice.ts
66.67% 50% 50% 66.67%
🟡
... / orderByPreferenceSlice.ts
58.33% 50% 33.33% 66.67%
🔴
... / nested-safe-wallet.ts
22% 0% 0% 22.45%
🔴
... / useSelectAvailableSigner.ts
45.45% 0% 0% 50%
🟢
... / useNestedSafeOwners.tsx
100% 100% 100% 100%
🟢
... / signers.ts
100% 90% 100% 100%
🟢
... / useIsNestedSafeOwner.ts
100% 100% 100% 100%
🟢
... / useAllOwnedSafes.ts
93.33% 33.33% 100% 92.86%
🟡
... / useAllSafesGrouped.ts
55.17% 0% 27.27% 65.22%
🔴
... / useAllSafes.ts
48.33% 21.43% 30% 54.9%
🟢
... / types.ts
100% 100% 100% 100%
🟡
... / index.tsx
77.27% 100% 60% 76.19%
🟢
... / index.tsx
66.67% 0% 0% 100%
🟢
... / index.tsx
66.67% 100% 0% 100%
🟢
... / index.tsx
84.09% 85% 71.43% 85.37%
🟢
... / bridge.ts
100% 100% 100% 100%
🟡
... / index.tsx
60% 0% 0% 62.5%
🟢
... / index.tsx
85.71% 0% 0% 100%
🟡
... / index.tsx
61.54% 0% 0% 66.67%
🔴
... / SingleAccountItem.tsx
48.57% 0% 0% 51.52%
🔴
... / useGetHref.ts
37.5% 0% 0% 42.86%
🟢
... / index.tsx
75% 0% 0% 80%
🟡
... / index.tsx
66.67% 0% 0% 71.43%
🔴
... / MultiAccountItem.tsx
33.01% 0% 0% 36.96%
🔴
... / SubAccountItem.tsx
53.19% 0% 0% 56.82%
🟡
... / index.tsx
63.64% 0% 0% 70%
🔴
... / utils.ts
25% 0% 0% 40%
🔴
... / useSafesSearch.ts
23.33% 0% 0% 25.93%
🔴
... / useTrackedSafesCount.ts
21.28% 0% 0% 23.81%
🔴
... / index.tsx
55.17% 0% 0% 57.14%
🔴
... / index.tsx
45.45% 0% 0% 47.62%
🔴
... / useVisitedSafes.ts
33.33% 0% 0% 35.29%
🟢
... / index.tsx
80.95% 66.67% 25% 85%
🟢
... / index.tsx
83.33% 100% 50% 90.91%
🟢
... / index.tsx
100% 100% 100% 100%
🟢
... / index.tsx
100% 100% 100% 100%
🟢
... / index.tsx
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.ts
92.31% (+0.39% 🔼)
80.56% (-3.59% 🔻)
95.45%
93.14% (+0.28% 🔼)
🟡
... / transaction-guards.ts
72.58% (-5.38% 🔻)
41.05% (-20.9% 🔻)
71.01% (-9.87% 🔻)
73.48% (-6.41% 🔻)
🔴
... / addedSafesSlice.ts
50% (-15.52% 🔻)
42.86% (-32.14% 🔻)
27.27% (-6.06% 🔻)
51.72% (-16.46% 🔻)
🟢
... / safeCoreSDK.ts
94.23% (+1.92% 🔼)
73.33% (-11.28% 🔻)
100% 93.48%
🔴
... / dispatch.ts
37.44% (-0.37% 🔻)
34.29% (-1.01% 🔻)
25%
36.51% (-0.39% 🔻)
🟢 src/utils/date.ts
76.19% (+0.58% 🔼)
75% (-15% 🔻)
75%
80.65% (+0.65% 🔼)
🟢
... / useSafeCreationData.ts
98.7% (-0.03% 🔻)
96.3% 100% 100%
🔴
... / index.ts
12.73% (-0.48% 🔻)
100% 0%
25% (-0.93% 🔻)
🟢
... / index.tsx
100%
50% (-50% 🔻)
100% 100%
🟡
... / index.tsx
67.74%
14.29% (-1.1% 🔻)
71.43% 66.67%
🟡
... / useIsValidExecution.ts
70.21% (-0.9% 🔻)
58.33% 60%
70.45% (-0.97% 🔻)
🟡
... / index.tsx
75% (-12.5% 🔻)
35% (-45% 🔻)
50% (-16.67% 🔻)
75% (-13.89% 🔻)
🟡
... / index.tsx
54.55% (-45.45% 🔻)
0% (-66.67% 🔻)
0% (-100% 🔻)
60% (-40% 🔻)
🟢
... / index.tsx
93.55% (-2.45% 🔻)
94.12% (+0.37% 🔼)
85.71% (-14.29% 🔻)
93.33% (-6.67% 🔻)
🟢
... / index.tsx
90% (-2.86% 🔻)
88.89% 66.67%
89.66% (-2.94% 🔻)
🟡
... / SignOrExecuteForm.tsx
66.37% (-19.17% 🔻)
73.56% (-2.91% 🔻)
27.27% (-15.58% 🔻)
65.14% (-19.67% 🔻)
🔴
... / CounterfactualForm.tsx
43.94% (-24.24% 🔻)
0% (-60.71% 🔻)
0% (-66.67% 🔻)
46.03% (-22.22% 🔻)
🟢
... / ExecuteForm.tsx
95.83%
84.62% (-1.87% 🔻)
100% 95.65%
🟢
... / SignForm.tsx
91.8% (-1.05% 🔻)
84.85% (-2.25% 🔻)
100%
92.98% (-1.25% 🔻)
🟢
... / tx-tracking.ts
87.18% (-0.7% 🔻)
77.78% (-3.47% 🔻)
100%
86.84% (-0.66% 🔻)
🟡
... / index.tsx
75.68% (-0.57% 🔻)
56.25% (+0.99% 🔼)
25% (-15% 🔻)
76.06% (-0.26% 🔻)
🟡
... / useTransactionType.tsx
62.75%
34.69% (-2.56% 🔻)
100% 63.27%
🟢
... / index.tsx
86.21% (-2.25% 🔻)
90.48% (+43.11% 🔼)
33.33% (-16.67% 🔻)
88.89% (+0.89% 🔼)
🟢
... / tokenTransferParams.ts
96.3% (-3.7% 🔻)
80%
80% (-20% 🔻)
95.83% (-4.17% 🔻)
🟢
... / Deposit.tsx
76.92% (-1.65% 🔻)
0% 0%
83.33% (-1.28% 🔻)
🟢
... / useGetSafeInfo.ts
85% (+0.79% 🔼)
15.38% (-4.62% 🔻)
25% (-15% 🔻)
84.21% (-4.02% 🔻)
🟢
... / index.tsx
96% (-0.15% 🔻)
72.22% (+4.04% 🔼)
100% 100%
🟢
... / useTxPendingStatuses.ts
77.5% (-6.14% 🔻)
64.06% (-4.27% 🔻)
68.18% (-6.82% 🔻)
86.41% (-6.22% 🔻)
🟢
... / index.tsx
82.35% (-0.5% 🔻)
80.95% 40%
87.5% (-0.38% 🔻)
🟢
... / index.tsx
94.12% (-0.33% 🔻)
87.5% 100%
93.75% (-0.37% 🔻)
🟡
... / index.tsx
60.14% (+0.27% 🔼)
42.42% (-1.33% 🔻)
55.56%
60.87% (+0.29% 🔼)
🟢
... / SafeAppsDashboardSection.tsx
84.62% (-10.84% 🔻)
50%
50% (-25% 🔻)
84% (-11.24% 🔻)
🟢
... / index.tsx
100%
88.89% (-11.11% 🔻)
100% 100%
🟡 src/pages/_app.tsx
69.23% (-0.51% 🔻)
42.86% 0%
68% (-0.49% 🔻)
🟡
... / index.tsx
66.67% (-1.52% 🔻)
0% 0%
73.68% (-1.32% 🔻)

Test suite run success

1662 tests passing in 226 suites.

Report generated by 🧪jest coverage report action from 7668262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for QA
Development

Successfully merging this pull request may close these issues.

8 participants