Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix tests #4586

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Tests: Fix tests #4586

merged 6 commits into from
Dec 2, 2024

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Dec 2, 2024

What it solves

How this PR fixes it

  • Regex was added to add flexibility and avoid tests failing in the future.
  • Minor refactoring: removed redundant assertion for visibility and extra test steps.
  • Some tests fail due to local storage not set in GitHub Actions. To prevent tests from failing, accepting cookies was forced on UI in beforeEach hook that covers all existing tests. This steps may be reconsidered at a later date.

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Dec 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.67% (+0.01% 🔼)
14331/19454
🔴 Branches
51.76% (-0.04% 🔻)
3513/6787
🔴 Functions
57.12% (+0.05% 🔼)
2081/3643
🟡 Lines
75.26% (+0.01% 🔼)
13019/17298
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢 mocks/terms.md.js 75% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / gtm.ts
70.77%
60% (-3.64% 🔻)
50% 77.78%
🟢
... / index.tsx
94.12% (-0.17% 🔻)
75% 100%
96.67% (-0.11% 🔻)
🟢
... / index.tsx
96% (+2.45% 🔼)
93.75% (-0.37% 🔻)
100% (+14.29% 🔼)
100% (+6.67% 🔼)
🟢
... / custom.tsx
95% (-0.24% 🔻)
100% 75%
94.74% (-0.26% 🔻)
🟡
... / index.tsx
76.25% (+0.57% 🔼)
55.26% (-0.99% 🔻)
40% (+15% 🔼)
76.32% (+0.26% 🔼)

Test suite run success

1661 tests passing in 226 suites.

Report generated by 🧪jest coverage report action from ea9e758

@mike10ca mike10ca merged commit dc9327e into dev Dec 2, 2024
15 checks passed
@mike10ca mike10ca deleted the fix-tests-2 branch December 2, 2024 12:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants