fix: add cancellation overview #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://recovery_cancel--walletweb.review-wallet-web.5afe.dev |
iamacook
commented
Nov 23, 2023
| return ( | ||
| <TxCard> | ||
| <Box display="flex" flexDirection="column" alignItems="center" p={5}> | ||
| {/* TODO: Replace with correct icon when provided */} |
There was a problem hiding this comment.
@TanyaEfremova is aware of this as the designs were only changed yesterday.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Test suite run success1213 tests passing in 171 suites. Report generated by 🧪jest coverage report action from 92b54af |
katspaugh
approved these changes
Nov 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Partially improves #2763
How this PR fixes it
An overview of the cancellation process, as well as an info banner, has been added to the cancellation flow. All references to "skipping" a recovery attempt have been changed to "cancel".
How to test it
Ensure a recovery attempt is queued and cancel it. Observe the new overview screen, as well as tweaked text on the "New transaction" screen.
Screenshots
Checklist