-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove deprecated mobile pairing #2794
Conversation
Branch preview✅ Deploy successful! |
58e50c6
to
cdc30e9
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1095 tests passing in 154 suites. Report generated by 🧪jest coverage report action from a7b5102 |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
do we know why https://verify.walletconnect.com/... 404 appears during dapp connection? |
I have the issues with wallet WC -
|
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Those 404 errors have been there since the beginning. Regarding signing, what signer wallet are you using? Please make sure it supports Goerli, or try some other chain. |
Verified, mobile pairing info removed |
What it solves
Mobile pairing will be deprecated on Nov 15, so we can remove it from the code.