Refactor: update to Next 13 #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
katspaugh
commented
Aug 24, 2023
| @@ -1,4 +1,4 @@ | |||
| # <img src="/public/images/logo.svg" height="60" valign="middle" alt="Safe{Wallet}" /> | |||
| # <img src="/public/images/logo.svg" height="60" valign="middle" alt="Safe{Wallet}" style="background: #fff; padding: 20px; margin: 0 -20px" /> | |||
There was a problem hiding this comment.
It blends with the background in dark mode otherwise.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
reviewed
Aug 24, 2023
usame-algan
reviewed
Aug 24, 2023
katspaugh
changed the title
katspaugh
commented
Aug 24, 2023
iamacook
approved these changes
Aug 24, 2023
|
Went around the site, checking that it looks fine Safe creation/adding Is anything else I should cover let me know and I'll do it during the regression of the next RC. Note: I'll move it to QA done, but it seems that there are conflicst before merging it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Upgrades the app to Next 13.
Plus
yarn upgrade+ a few small changes in the readme and configs.How to test it
It touches a lot of places where internal links are used. It might potentially break some link-related CSS/layout.
So I would suggest testing it by opening all routes and checking that they look the same.