-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototype: tKey MPC integration #2424
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
[warning] react-hooks/exhaustive-deps
Report generated by eslint-plus-action |
); | ||
} | ||
} catch (error) { | ||
console.log('Hello'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello to you as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahaha. This is the example service worker copied from the web3auth guide. It is def. not production ready.
I think it will also need adjustments as it hardcodes localhost:3000
https://web3auth.io/docs/content-hub/guides/tkey-mpc#setting-up-the-service-worker
blockExplorer: 'https://goerli.etherscan.io', | ||
ticker: 'ETH', | ||
tickerName: 'Ethereum', | ||
chainId: hexlify(Number(chain.chainId)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it giving anything different than Number(chain.chainId).toString(16)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I will use the your suggested conversion to reduce ethers dependencies.
const fromAddress = (await web3Local?.send('eth_accounts', []))[0] | ||
setWalletAddress(fromAddress) | ||
const accountsResponse = await web3Local?.send('eth_accounts', []) | ||
if (isArray(accountsResponse) && accountsResponse.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a native Array.isArray
.
Prototype implementation using tKey MPC for Social Logins.
It is possible to create new wallets, add a backup factor, reset (delete) the whole account and to sign transactions on Görli.