Fix: show known addresses in decoded tx data #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
katspaugh
commented
Aug 21, 2023
Comment on lines
-4
to
-8
|
|
||
| /* Reduce space between name/address for clarity between rows */ | ||
| .address > div { | ||
| line-height: 1; | ||
| } |
There was a problem hiding this comment.
Removed this because it cuts the hanging parts of some letters:
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
approved these changes
Aug 21, 2023
|
Question. Should the name also show up in the tx form? or is out of the scope of this ticket?
|
|
@francovenica during tx creation we don't have this info, but I added it when confirming an existing tx. 👍 |
|
indeed, it works for tx that have been already proposed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2422
How this PR fixes it
Displays name and icon for known addresses in decoded tx details and in multisend details.
How to test it
Screenshots