fix: fetch safe overviews including untrusted token fiatTotal (#4495)

* fix: fetch safe overviews including untrusted token fiatTotal * test: fix safeOverviews.test.ts * chore: add comment explaining why trusted needs to be false
safe-global · Nov 22, 2024 · 43d158f · 43d158f
1 parent 74a7e24
commit 43d158f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/store/__tests__/safeOverviews.test.ts b/src/store/__tests__/safeOverviews.test.ts
@@ -175,7 +175,7 @@ describe('safeOverviews', () => {
           ],
           {
             currency: 'usd',
-            trusted: true,
+            trusted: false,
             exclude_spam: true,
           },
         )
@@ -344,12 +344,12 @@ describe('safeOverviews', () => {
       expect(mockedGetSafeOverviews).toHaveBeenCalledTimes(2)
       expect(mockedGetSafeOverviews).toHaveBeenCalledWith(
         request.safes.slice(0, 10).map((safe) => `1:${safe.address}`),
-        { currency: 'usd', exclude_spam: true, trusted: true },
+        { currency: 'usd', exclude_spam: true, trusted: false },
       )
 
       expect(mockedGetSafeOverviews).toHaveBeenCalledWith(
         request.safes.slice(10).map((safe) => `1:${safe.address}`),
-        { currency: 'usd', exclude_spam: true, trusted: true },
+        { currency: 'usd', exclude_spam: true, trusted: false },
       )
     })
   })

diff --git a/src/store/api/gateway/safeOverviews.ts b/src/store/api/gateway/safeOverviews.ts
@@ -35,7 +35,11 @@ class SafeOverviewFetcher {
     currency: string
   }) {
     return await getSafeOverviews(safeIds, {
-      trusted: true,
+      /**
+       * This flag can only be set once for all cross chain `safeIds`.
+       * If we set `trusted` to `true` we will get 0 as `fiatTotal` for all Safes on networks without Default tokenlists.
+       */
+      trusted: false,
       exclude_spam: true,
       currency,
       wallet_address: walletAddress,