Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend Safe wallet provider tests #2608

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Extends test coverage of SafeWalletProvider and useSafeWalletProvider

How this PR fixes it

All explicit methods of SafeWalletProvider and useSafeWalletProvider are now covered by unit tests.

How to test it

Observe the tests for SafeWalletProvider and useSafeWalletProvider passing.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from usame-algan October 10, 2023 11:12
@iamacook iamacook self-assigned this Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Branch preview

✅ Deploy successful!

https://safe_wallet_provider_tests--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook
Copy link
Member Author

As these are just tests, I'm going to merge them directly.

@iamacook iamacook merged commit 847a4e0 into nect Oct 12, 2023
8 of 9 checks passed
@iamacook iamacook deleted the safe-wallet-provider-tests branch October 12, 2023 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant