Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: collapse notifications if more than max + 1 #2597

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix: collapse notifications if more than max + 1 #2597

merged 1 commit into from
Oct 6, 2023

Conversation

katspaugh
Copy link
Member

What it solves

A fix for #2576, the +1 logic wasn't checked in enough places.

@katspaugh katspaugh requested a review from iamacook October 6, 2023 07:39
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Branch preview

✅ Deploy successful!

https://fix_max--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh changed the title Fix: collapse notification is more than max + 1 Fix: collapse notifications if more than max + 1 Oct 6, 2023
@francovenica
Copy link
Contributor

Looks good

I get to see the 5 notifications in a single page
The "x other notifications" shows fine after the 6th notification and on.

@katspaugh katspaugh merged commit 011a0c6 into dev Oct 6, 2023
9 checks passed
@katspaugh katspaugh deleted the fix-max branch October 6, 2023 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants