fix: rename notification feature variables

safe-global · Oct 6, 2023 · 6d36fb7 · 6d36fb7
1 parent 3ac6276
commit 6d36fb7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/components/settings/PushNotifications/PushNotificationsBanner/index.tsx b/src/components/settings/PushNotifications/PushNotificationsBanner/index.tsx
@@ -87,7 +87,7 @@ export const _getSafesToRegister = (
 }
 
 export const PushNotificationsBanner = ({ children }: { children: ReactElement }): ReactElement => {
-  const isNotificationsEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
+  const isNotificationFeatureEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
   const chain = useCurrentChain()
   const totalAddedSafes = useAppSelector(selectTotalAdded)
   const { safe, safeAddress } = useSafeInfo()
@@ -101,7 +101,7 @@ export const PushNotificationsBanner = ({ children }: { children: ReactElement }
   const isSafeAdded = !!addedSafesOnChain?.[safeAddress]
   const isSafeRegistered = getPreferences(safe.chainId, safeAddress)
   const shouldShowBanner =
-    isNotificationsEnabled && !isPushNotificationBannerDismissed && isSafeAdded && !isSafeRegistered
+    isNotificationFeatureEnabled && !isPushNotificationBannerDismissed && isSafeAdded && !isSafeRegistered
 
   const { registerNotifications } = useNotificationRegistrations()
 

diff --git a/src/components/settings/PushNotifications/hooks/useNotificationTracking.ts b/src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
@@ -70,11 +70,11 @@ const handleTrackCachedNotificationEvents = async (
 }
 
 export const useNotificationTracking = (): void => {
-  const isNotificationsEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
+  const isNotificationFeatureEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
 
   useEffect(() => {
-    if (typeof indexedDB !== 'undefined' && isNotificationsEnabled) {
+    if (typeof indexedDB !== 'undefined' && isNotificationFeatureEnabled) {
       handleTrackCachedNotificationEvents(createNotificationTrackingIndexedDb())
     }
-  }, [isNotificationsEnabled])
+  }, [isNotificationFeatureEnabled])
 }
diff --git a/src/components/settings/SettingsHeader/index.tsx b/src/components/settings/SettingsHeader/index.tsx
@@ -11,10 +11,10 @@ import { FEATURES } from '@/utils/chains'
 
 const SettingsHeader = (): ReactElement => {
   const safeAddress = useSafeAddress()
-  const isNotificationsEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
+  const isNotificationFeatureEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
 
   const navItems = safeAddress ? settingsNavItems : generalSettingsNavItems
-  const filteredNavItems = isNotificationsEnabled
+  const filteredNavItems = isNotificationFeatureEnabled
     ? navItems
     : navItems.filter((item) => item.href !== AppRoutes.settings.notifications)
 

diff --git a/src/pages/settings/notifications.tsx b/src/pages/settings/notifications.tsx
@@ -7,9 +7,9 @@ import { useHasFeature } from '@/hooks/useChains'
 import { FEATURES } from '@/utils/chains'
 
 const NotificationsPage: NextPage = () => {
-  const isNotificationsEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
+  const isNotificationFeatureEnabled = useHasFeature(FEATURES.PUSH_NOTIFICATIONS)
 
-  if (!isNotificationsEnabled) {
+  if (!isNotificationFeatureEnabled) {
     return null
   }