feat(Wallet): Vertical Slide #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the current version
Branch preview✅ Deployed successfully in branch deployment: |
DiogoSoaress
force-pushed
the
wallet-vertical-slide
branch
from
3d3f608
to
7faf95b
Compare
DiogoSoaress
force-pushed
the
wallet-vertical-slide
branch
from
7faf95b
to
a9eea1d
Compare
iamacook
reviewed
Oct 30, 2024
| const [selectedIndex, setSelectedIndex] = useState(0) | ||
|
|
||
| const itemsImages = items.map((item) => item.image) | ||
| const icons = [<RecoveryIcon key="recovery" />, <ScanIcon key="scan" />, <MultipleKeysIcon key="multiple-keys" />] |
There was a problem hiding this comment.
Nit: we can move this outside of the component.
Comment on lines
49
to
50
| {itemsImages[selectedIndex] ? ( | ||
| <img src={itemsImages[selectedIndex].src} alt={itemsImages[selectedIndex].alt} className={css.image} /> |
There was a problem hiding this comment.
We can extract itemsImages[selectedIndex] to a variable to simplify this.
| // Change index every 5 seconds | ||
| useEffect(() => { | ||
| const interval = setInterval(() => { | ||
| setSelectedIndex((prevIndex) => (prevIndex + 1) % items?.length) |
There was a problem hiding this comment.
This will return NaN if items is undefined.
There was a problem hiding this comment.
I initiate items to 0 in the received props
There was a problem hiding this comment.
In which case, we don't need the optional chaining.
Comment on lines
+18
to
+20
| const handleCardClick = (index: number) => { | ||
| setSelectedIndex(index) | ||
| } |
There was a problem hiding this comment.
Nit: this is somewhat neglible. You can just call setSelectedIndex directly.
There was a problem hiding this comment.
I prefer to leave the click handler
iamacook
approved these changes
Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implements the Vertical Slider
Figma
https://www.figma.com/design/qtXXlwdslAze6yNbLLzIRa/Website-redesign-2.0?node-id=16164-3355&t=UyEbY16dBeLFg4eE-4