Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Wallet): Big cards grid #448

Merged
merged 16 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/components/Wallet/BigCardsGrid/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { Container, Grid } from '@mui/material'
import type { BaseBlock } from '@/components/Home/types'
import layoutCss from '@/components/common/styles.module.css'
import getComponentByName from '@/lib/getComponentByName'

const BigCardsGrid = ({ items }: { items: Array<BaseBlock['items'] & { component: string }> }) => (
<Container className={layoutCss.containerShort}>
<Grid container spacing={{ xs: '30px', xl: '50px' }}>
{items?.map((item, index) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no items, this will still render the Container. Is this expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is static so I think this can't really become an issue but I made it render conditionally nevertheless. Thanks for the catch.

const { component } = item

const CardComponent = getComponentByName(`${component}`, () => <></>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to fallback to an "empty" component?

Suggested change
const CardComponent = getComponentByName(`${component}`, () => <></>)
const CardComponent = getComponentByName(component, () => <></>)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a suitable fallback. Do you have any other suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure - I'll leave it up to you.


return (
<Grid key={index} item xs={12} md={6}>
<CardComponent {...item} />
</Grid>
)
})}
</Grid>
</Container>
)

export default BigCardsGrid
19 changes: 19 additions & 0 deletions src/components/Wallet/BigImageCard/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { Typography } from '@mui/material'
import type { BaseBlock } from '@/components/Home/types'
import css from './styles.module.css'

const BigImageCard = ({ caption, title, text, image }: BaseBlock) => (
<div className={css.card}>
<Typography variant="caption">{caption}</Typography>

<img {...image} className={css.image} />

<Typography variant="h4" className={css.title}>
{title}
</Typography>

{text ? <Typography color="primary.light">{text}</Typography> : null}
</div>
)

export default BigImageCard
26 changes: 26 additions & 0 deletions src/components/Wallet/BigImageCard/styles.module.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
.card {
outline: 1px solid var(--mui-palette-border-light);
border-radius: 16px;
padding: 16px;
display: flex;
flex-direction: column;
align-items: center;
justify-content: flex-start;
text-align: center;
height: 100%;
}

.image {
width: 240px;
}

.title {
width: 80%;
margin-bottom: 24px;
}

@media (min-width: 600px) {
.card {
padding: 32px;
}
}
9 changes: 1 addition & 8 deletions src/components/Wallet/index.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
import walletContent from '@/content/wallet.json'
import type { getStaticProps } from '@/pages/wallet'
import type { InferGetStaticPropsType } from 'next'
import ChainsContext from '@/contexts/ChainsContext'
import PageContent from '../common/PageContent'

export const Wallet = (props: InferGetStaticPropsType<typeof getStaticProps>) => (
<ChainsContext.Provider value={props.chainsData}>
<PageContent content={walletContent} path="wallet.json" />
</ChainsContext.Provider>
)
export const Wallet = () => <PageContent content={walletContent} path="wallet.json" />
25 changes: 25 additions & 0 deletions src/content/wallet.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,31 @@
],
"component": "common/TitleSlidingIcons"
},
{
"items": [
{
"caption": "Individual users",
"title": "Secure Your Savings Beyond a Seed Phrase",
"text": "Protect your assets with multi-signature security, giving you peace of mind without relying solely on a seed phrase.",
"image": {
"src": "/images/Home/safe-shield.png",
"alt": "Safe Smart Account shield"
},
"component": "Wallet/BigImageCard"
},
{
"caption": "Organizations",
"title": "Manage Assets Together, Securely",
"text": "Collaboratively manage your organization's assets with multi-signature approvals, ensuring security and transparency every step of the way.",
"image": {
"src": "/images/Home/safe-shield.png",
"alt": "Safe Smart Account shield"
},
"component": "Wallet/BigImageCard"
}
],
"component": "Wallet/BigCardsGrid"
},
{
"title": "Introducing<br>Native Swaps",
"caption": "New feature",
Expand Down
17 changes: 2 additions & 15 deletions src/pages/wallet.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,6 @@
import type { InferGetStaticPropsType, NextPage } from 'next'
import type { NextPage } from 'next'
import { Wallet } from '@/components/Wallet'
import { loadChainsData } from '@/lib/loadChainsData'

const WalletPage: NextPage<InferGetStaticPropsType<typeof getStaticProps>> = (props) => {
return <Wallet {...props} />
}

export async function getStaticProps() {
const chainsData = await loadChainsData()

return {
props: {
chainsData,
},
}
}
const WalletPage: NextPage = () => <Wallet />

export default WalletPage
Loading