Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new chains to Homepage marquee #240

Merged
merged 4 commits into from
Sep 19, 2023
Merged

feat: add new chains to Homepage marquee #240

merged 4 commits into from
Sep 19, 2023

Conversation

DiogoSoaress
Copy link
Member

@DiogoSoaress DiogoSoaress commented Sep 15, 2023

Note: Waiting for input in chains logos

What it solves

Adds the newly supported chains

  • Polygon zkEVM
  • zkSync Era

to the Homepage marquee.

How this PR fixes it

  • Adds the new networks info to the Home content file

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Branch preview

✅ Deployed to dev:

https://safe-web-landing.dev.5afe.dev

@DiogoSoaress DiogoSoaress marked this pull request as ready for review September 19, 2023 10:00
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look blurry, they should be 80x80.

@TanyaEfremova
Copy link
Contributor

logo-polygon-zkevm logo-zksyncera Please use these icons, they are 2x size (80x80).

@DiogoSoaress
Copy link
Member Author

I've used 160x160 as they were still blurry at 80x80

@katspaugh
Copy link
Member

They are displayed at 40x40 on the website though. 2x should be enough. And don't forget to run them through tinypng.

@DiogoSoaress
Copy link
Member Author

I've run them through tinypng ✅
Also synced with Tanya to update the UI Kit with better asset resolution on Figma

@DiogoSoaress DiogoSoaress merged commit 5d555c9 into main Sep 19, 2023
5 checks passed
@DiogoSoaress DiogoSoaress deleted the add-new-chains branch September 19, 2023 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants