Add Server Side Events endpoint #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
approved these changes
Sep 27, 2023
| return this.eventsService.getEventsObservableForSafe(safe); | ||
|
|
||
| throw new BadRequestException('Not valid EIP55 address', { | ||
| description: `${safe} is not a valid EIP55 Safe address`, |
There was a problem hiding this comment.
Should we consider check if the address is a Safe address?
There was a problem hiding this comment.
It would add too many dependencies for the service, in my opinion
There was a problem hiding this comment.
But it's a good observation, depending on traffic we have to think on how to protect this endpoint, maybe a flag to disable the feature in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an endpoint to subscribe to Server Side Events. Events will have the same format as the webhook ones. Also, when subscribing to a Safe, if the Safe is present in multiple chains all the events will be received.
New endpoint will be
/events/sse/<checksummedSafeAddress>