Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communicator is an argument when creating SDK #569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ScreamingHawk
Copy link

Add communicator as an optional argument for SDK. This allows communicator to be overridden with minimal overheads.

Copy link

changeset-bot bot commented Mar 29, 2024

⚠️ No Changeset found

Latest commit: d968b23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 29, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ScreamingHawk
Copy link
Author

ScreamingHawk commented Mar 29, 2024

Re changeset, this change is backwards compatible and could be a minor/patch bump

@ScreamingHawk
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant