-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow phpstan v1 #130
base: 5.1
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.1 #130 +/- ##
=========================================
Coverage 99.72% 99.72%
+ Complexity 118 110 -8
=========================================
Files 7 7
Lines 365 365
=========================================
Hits 364 364
Misses 1 1 ☔ View full report in Codecov by Sentry. |
34e9b66
to
5e0a90c
Compare
Now I am struggling to get PHP 8.4 with phpstan 1.11 to actually report a problem with deprecated stuff. |
for deprecations you need phpstan-deprecation-rules |
47c76af
to
9109a3e
Compare
9109a3e
to
467bfe3
Compare
https://github.com/sabre-io/event/actions/runs/10575734407/job/29300024688?pr=130
But we have a way to use php-cs-fixer to find these anyway, so I will make a different PR to do that. |
"uri" repo is working running phpstan 1.11 on PHP 8.4
So I am hoping that I could find some config that will allow old phpstan 0.12 to keep running with PHP 7.1, and phpstan 1.11 to run with PHP 8.4
But phpstan 1.11 with PHP 8.4 is giving:
"Result is incomplete because of severe errors"
"Some parallel worker jobs have not finished. while running parallel worker"
But the deprecated messages that are logged are similar to what "uri" logs.
There must be difference in something!