Support icons in selected item also, not only in list of options #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow showing icons or other custom content in selected item when the select is closed
|
@AlexeySemenko can you please add more context to the PR, including running tests and maybe including tests runs (example, something more aligned with this PR) |
gnbm
reviewed
Jun 4, 2024
gnbm
reviewed
Jun 4, 2024
|
After adding the selectedLabelRenderer property
|
abenhamdine
suggested changes
Jun 5, 2024
Co-authored-by: Arnaud Benhamdine <[email protected]>
gnbm
requested changes
Jun 5, 2024
…ySemenko/virtual-select into add-icons-to-selected-item
|
@AlexeySemenko once you resolve the conflicts the PR should be good to go and get merged 👍🏻 |
conflict resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added config option selectedLabelRenderer, same as labelRenderer to allow showing icons or other custom content in selected item when the select is closed