Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bungee support & fixed migrations running without data set #241

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SgtJalau
Copy link

No description provided.

Copy link
Collaborator

@Silthus Silthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I have some small change requests, otherwise looks good :)

Also please adjust the readme to include a reference to the new bungeecord support.

build.gradle Outdated
@@ -61,6 +63,7 @@ dependencies {

api 'io.ebean:ebean:12.12.0'
api 'io.ebean:ebean-querybean:12.12.1'
compileOnly "net.md-5:bungeecord-api:1.17-R0.1-SNAPSHOT"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make this use the implementation keyword instead of the old compileOnly?


import net.md_5.bungee.api.plugin.Plugin;

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unneeded comment. Source control will show the author and date.

build.gradle Outdated
@@ -61,6 +63,7 @@ dependencies {

api 'io.ebean:ebean:12.12.0'
api 'io.ebean:ebean-querybean:12.12.1'
compileOnly "net.md-5:bungeecord-api:1.17-R0.1-SNAPSHOT"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please use the mcVersion variable instead of hard coding the version in the dependency.

@@ -0,0 +1,4 @@
name: EbeanWrapper
version: 1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be handled by the semantic-release plugin in the update-version.sh script. But I can also add this later.

@Silthus
Copy link
Collaborator

Silthus commented Dec 27, 2021

The commit messages must also be updated to match the semantic versioning pattern.

@SgtJalau
Copy link
Author

Hey, sorry I will make the changes soon!

@SgtJalau SgtJalau changed the title Fixed migrations running without data set & bungee support feat: bungee support & fixed migrations running without data set Jan 17, 2022
@SgtJalau
Copy link
Author

The commit messages must also be updated to match the semantic versioning pattern.

Is it fine now or what naming pattern do you mean?

Also fixed the other things apart from the update-version.sh change.

@Silthus
Copy link
Collaborator

Silthus commented Jan 20, 2022

The tests and build are failing. Once fixed I will merge the PR.

13 refactored a few things, so that will have to be done at a different time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants