WiP

s9e · Dec 28, 2023 · 235be3a · 235be3a
1 parent ef95d34
commit 235be3a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/NodeComparator.php b/src/NodeComparator.php
@@ -27,7 +27,7 @@ class NodeComparator
 	// https://github.com/php/php-src/blob/master/ext/dom/node.c
 	public static function isEqualNode(?DOMNode $node, ?DOMNode $otherNode): bool
 	{
-		if (!isset($node, $otherNode) || $node->nodeType !== $otherNode->nodeType || $node->nodeName !== $otherNode->nodeName)
+		if (!isset($node, $otherNode) || $node->nodeType !== $otherNode->nodeType)
 		{
 			return false;
 		}

diff --git a/tests/NodeComparatorTest.php b/tests/NodeComparatorTest.php
@@ -381,12 +381,12 @@ public function testIsEqualEntityDeclarationNode()
 			</html>
 		EOT);
 
-		$this->assertIsEqualNode(true, $dom1->doctype->entities['bar'], $dom2->doctype->entities['bar']);
-		$this->assertIsEqualNode(false, $dom1->doctype->entities['bar'], $dom2->doctype->entities['barbar']);
-		$this->assertIsEqualNode(false, $dom1->doctype->entities['bar'], $dom2->doctype->entities['foo']);
-		$this->assertIsEqualNode(false, $dom1->doctype->entities['foo'], $dom2->doctype->entities['bar']);
-		$this->assertIsEqualNode(false, $dom1->doctype->entities['foo'], $dom2->doctype->entities['barbar']);
-		$this->assertIsEqualNode(true, $dom1->doctype->entities['foo'], $dom2->doctype->entities['foo']);
+		$this->assertIsEqualNode(true, $dom1->doctype->entities->getNamedItem('bar'), $dom2->doctype->entities->getNamedItem('bar'));
+		$this->assertIsEqualNode(false, $dom1->doctype->entities->getNamedItem('bar'), $dom2->doctype->entities->getNamedItem('barbar'));
+		$this->assertIsEqualNode(false, $dom1->doctype->entities->getNamedItem('bar'), $dom2->doctype->entities->getNamedItem('foo'));
+		$this->assertIsEqualNode(false, $dom1->doctype->entities->getNamedItem('foo'), $dom2->doctype->entities->getNamedItem('bar'));
+		$this->assertIsEqualNode(false, $dom1->doctype->entities->getNamedItem('foo'), $dom2->doctype->entities->getNamedItem('barbar'));
+		$this->assertIsEqualNode(true, $dom1->doctype->entities->getNamedItem('foo'), $dom2->doctype->entities->getNamedItem('foo'));
 	}
 
 	public function testIsEqualEntityNotationNode()