docs/decisions: Add severity labels ADR #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmoutoussamy commit is missing the DCO I'd suggest running a |
|
@vmoutoussamy also, when amending the commit, please add the subsystem where this change is happening to the commit title. Like, |
jecluis
requested changes
Oct 12, 2023
votdev
previously requested changes
Oct 12, 2023
tserong
reviewed
Oct 12, 2023
vmoutoussamy
force-pushed
the
severity
branch
from
d30046f to
13f826a
Compare
vmoutoussamy
changed the title
vmoutoussamy
force-pushed
the
severity
branch
from
e29d3e1 to
7c4a35e
Compare
|
@vmoutoussamy you'll need to do a |
jecluis
requested changes
Oct 13, 2023
vmoutoussamy
force-pushed
the
severity
branch
from
77c3c61 to
f23a28d
Compare
vmoutoussamy
force-pushed
the
severity
branch
2 times, most recently
from
9eb9419 to
2d91713
Compare
|
@vmoutoussamy right now your commit message looks like this: This is a result of all the squash/fixup you did on the different patches. We don't want this messy message, we want something lean and simple. I would suggest you run a |
|
@vmoutoussamy ping |
Update docs/decisions/0015-severity-labels.md Co-authored-by: Volker Theile <[email protected]> Co-authored-by: Tim Serong <[email protected]> Signed-off-by: Vincent Moutoussamy <[email protected]>
vmoutoussamy
force-pushed
the
severity
branch
from
2d91713 to
e48464b
Compare
jecluis
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding the file s3gw/docs/decisions/0015-severity-labels.md, for discussing the decision to use a new set of labels for severity.
Issue ticket number and link
Checklist before requesting a review