Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Add filesystems:ceph:s3gw repomd.xml #738

Conversation

tserong
Copy link
Contributor

@tserong tserong commented Oct 4, 2023

Without this, the subsequent zypper install ; zypper ref is effectively a no-op if docker build has already been run and cached that layer, which means we don't pick up updated package versions.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

Without this, the subsequent `zypper install ; zypper ref` is
effectively a no-op if docker build has already been run and
cached that layer, which means we don't pick up updated package
versions.

Signed-off-by: Tim Serong <[email protected]>
@tserong tserong requested a review from jecluis October 4, 2023 07:44
Copy link
Contributor

@jecluis jecluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably one of the weirdest patches I've reviewed in the last year

@tserong tserong merged commit f23daf3 into s3gw-tech:main Oct 4, 2023
2 checks passed
@tserong tserong deleted the wip-dockerfile-invalidate-cache-on-deps-change branch October 4, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants