Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UI: make explicit description for default retention for buckets #748

Closed
giubacc opened this issue Oct 6, 2023 · 3 comments · Fixed by s3gw-tech/s3gw-ui#278
Closed
Labels
area/ui User Interface kind/bug Something isn't working
Milestone

Comments

@giubacc
Copy link

giubacc commented Oct 6, 2023

Describe the bug A clear and concise description of what the bug is.

Minor issue, but IMO worth to be addressed.
When creating a bucket and setting the default retention mode, I would make explicit that this is a default retention mode.
Let's keep in mind that this setting can be changed at any time. Also user can decide, explicitly, with the APIs to not even put a retention over an object (or/and over a specific version); that is completely optional.
Default retention mode only says that when there isn't an explicit setting from the user, the object takes the current default retention mode.
The current description suggests that every object will take the retention set there.
So I would change that.

image

@github-project-automation github-project-automation bot moved this to Backlog in S3GW Oct 6, 2023
@giubacc giubacc added the area/ui User Interface label Oct 6, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Oct 6, 2023
@giubacc giubacc added kind/bug Something isn't working triage/waiting Waiting for triage and removed triage/waiting Waiting for triage labels Oct 6, 2023
@votdev
Copy link
Contributor

votdev commented Oct 17, 2023

The current description suggests that every object will take the retention set there.

Any suggestions on how to word the notice text instead?

@giubacc
Copy link
Author

giubacc commented Oct 17, 2023

My suggestion, something like:

Title: "Default bucket retention mode"
SubTitle: "Applied to any object put without an explicit retention mode set"

@jecluis
Copy link
Contributor

jecluis commented Oct 19, 2023

pushing to v0.23.0

@jecluis jecluis removed the triage/waiting Waiting for triage label Oct 19, 2023
@jecluis jecluis added this to the v0.23.0 milestone Oct 19, 2023
@votdev votdev moved this from Backlog to In Progress 🏗️ in S3GW Oct 23, 2023
@votdev votdev moved this from In Progress 🏗️ to In Review 👀 in S3GW Oct 23, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done in S3GW Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants