Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicit description for default retention for buckets #278

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Oct 23, 2023

@votdev votdev added kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API area/ui User Interface labels Oct 23, 2023
@votdev votdev added this to the v0.23.0 milestone Oct 23, 2023
@votdev votdev requested a review from giubacc October 23, 2023 14:07
@votdev votdev self-assigned this Oct 23, 2023
@votdev votdev force-pushed the issue_748_retention_desc branch from ae85a6a to 57e6e69 Compare October 23, 2023 14:09
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (492603d) 95.85% compared to head (57e6e69) 95.85%.

❗ Current head 57e6e69 differs from pull request most recent head c9292a9. Consider uploading reports for the commit c9292a9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          15       15           
  Lines         966      966           
=======================================
  Hits          926      926           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@votdev votdev force-pushed the issue_748_retention_desc branch from 57e6e69 to c9292a9 Compare October 23, 2023 14:12
@votdev votdev merged commit 7fe5e7f into s3gw-tech:main Oct 25, 2023
6 checks passed
@votdev votdev deleted the issue_748_retention_desc branch October 25, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UI: make explicit description for default retention for buckets
1 participant