Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] s3gw-ui: allow specifying custom certificate authorities (CA) for self-signed certificates #740

Open
Tracked by #388
jecluis opened this issue Oct 4, 2023 · 1 comment
Assignees
Labels
area/containers area/ui User Interface kind/enhancement Change that positively impacts existing code triage/next-candidate This could be moved to the next milestone

Comments

@jecluis
Copy link
Contributor

jecluis commented Oct 4, 2023

With s3gw-tech/s3gw-ui#269 as a quick fix to https://github.com/aquarist-labs/s3gw/issues/737 , we are essentially disabling SSL certificate validation between the UI backend and the s3gw service.

This is less than ideal, because we are breaking the trust relationship we must ensure between the UI backend and the s3gw service.

Instead, we should ensure we have a way to provide the CA used to sign the self-signed certificates to the UI backend container, so we can ensure the validity of the certificates even if self-signed.

At this point it's not clear how this should be implemented.

In a kubernetes environment, we could have the CA being provided as a secret, and then magically used to validate the certificates. It will depend on how cert-manager does self-signed certificates, and whether it creates a CA. This also requires some research.

@jecluis jecluis added kind/enhancement Change that positively impacts existing code area/ui User Interface labels Oct 4, 2023
@jecluis jecluis added this to S3GW Oct 4, 2023
@github-project-automation github-project-automation bot moved this to Backlog in S3GW Oct 4, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Oct 4, 2023
@jecluis jecluis self-assigned this Oct 16, 2023
@jecluis jecluis added priority/1 Should be fixed for next release area/containers and removed triage/waiting Waiting for triage labels Oct 16, 2023
@jecluis jecluis added this to the v0.23.0 milestone Oct 16, 2023
@jecluis
Copy link
Contributor Author

jecluis commented Oct 25, 2023

This is mostly relevant for contexts outside of a LH deployment, because

  1. LH controller deploys the s3gw-ui container in the same pod as the s3gw container, effectively allowing us to do inner-pod communication between the two
  2. Assuming we get to have an ingress shared between LH and the various s3gw-ui instances, with the latter being subpaths in the longhorn UI URL, we get a free SSL certificate out of it (the one for the LH UI as a whole)

Hence,

For 1. we can ignore the SSL validity, we can even do plain HTTP, because the traffic should be limited and isolated to the pod.
For 2. we don't need to care about the SSL certificate for the various s3gw-ui instances, leaving it up to the user to handle their own CA.

For these reasons, we are pushing this issue until after LH 1.6, and we'll reevaluate its priority around v0.25.0.

@jecluis jecluis modified the milestones: v0.23.0, v0.25.0 Oct 25, 2023
@jecluis jecluis added triage/next-candidate This could be moved to the next milestone and removed priority/1 Should be fixed for next release labels Mar 20, 2024
@jecluis jecluis added this to s3gw Mar 20, 2024
@jecluis jecluis moved this to Backlog in s3gw Mar 20, 2024
@jecluis jecluis removed this from the v0.25.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/containers area/ui User Interface kind/enhancement Change that positively impacts existing code triage/next-candidate This could be moved to the next milestone
Projects
Status: Backlog
Development

No branches or pull requests

1 participant