Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Backend: SSL support #591

Open
Tracked by #388
jecluis opened this issue Jun 17, 2023 · 1 comment
Open
Tracked by #388

UI/Backend: SSL support #591

jecluis opened this issue Jun 17, 2023 · 1 comment
Assignees
Labels
area/ui User Interface kind/feature New functionality or support for something triage/proposal for closure There are reasons for this issue to be closed

Comments

@jecluis
Copy link
Contributor

jecluis commented Jun 17, 2023

What needs to be done

The s3gw-ui backend will need to present both the UI (at /), as well as the API (at /api/) with SSL support.

Why it needs to be done

Because security.

Acceptance Criteria

s3gw-ui backend deployment runs on port 443, supporting HTTPS connections, with a user-specified certificate.

Additional Information

This will likely require the SSL certificate to be configurable, most likely via environment variables.

@jecluis jecluis added area/ui User Interface kind/feature New functionality or support for something labels Jun 17, 2023
@jecluis jecluis added this to S3GW Jun 17, 2023
@github-project-automation github-project-automation bot moved this to Backlog in S3GW Jun 17, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Jun 17, 2023
@jhmarina jhmarina added triage/next-candidate This could be moved to the next milestone and removed triage/waiting Waiting for triage labels Jul 4, 2023
@votdev votdev added this to the v0.22.0 milestone Sep 20, 2023
@votdev votdev added priority/0 Needs to go into the next release or force a patch triage/waiting Waiting for triage labels Sep 20, 2023
@jhmarina jhmarina moved this from Backlog to Scheduled in S3GW Sep 21, 2023
@jecluis jecluis self-assigned this Oct 4, 2023
@jecluis
Copy link
Contributor Author

jecluis commented Oct 25, 2023

Pushing this to post v0.23.0, as per the reasoning on #740 :

LH controller deploys the s3gw-ui container in the same pod as the s3gw container, effectively allowing us to do inner-pod communication between the two

and

we can ignore the SSL validity, we can even do plain HTTP, because the traffic should be limited and isolated to the pod.

While of the utmost importance, this will not be required for LH 1.6.

@jecluis jecluis modified the milestones: v0.22.0, v0.25.0 Oct 25, 2023
@jecluis jecluis added priority/1 Should be fixed for next release and removed triage/next-candidate This could be moved to the next milestone priority/0 Needs to go into the next release or force a patch triage/waiting Waiting for triage labels Oct 25, 2023
@jecluis jecluis moved this from Scheduled to Backlog in S3GW Oct 25, 2023
@jecluis jecluis added triage/proposal for closure There are reasons for this issue to be closed and removed priority/1 Should be fixed for next release labels Mar 20, 2024
@jecluis jecluis removed this from the v0.25.0 milestone Mar 20, 2024
@jecluis jecluis added this to s3gw Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface kind/feature New functionality or support for something triage/proposal for closure There are reasons for this issue to be closed
Projects
Status: No status
Development

No branches or pull requests

3 participants