Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/ui: allow setting custom registry #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jecluis
Copy link
Contributor

@jecluis jecluis commented Jul 30, 2023

We were relying on the custom registry value used for s3gw, but we may want to use a different one.

Signed-off-by: Joao Eduardo Luis <[email protected]>

We were relying on the custom registry value used for s3gw, but we may
want to use a different one.

Signed-off-by: Joao Eduardo Luis <[email protected]>
@jecluis jecluis added the kind/enhancement Change that positively impacts existing code label Jul 30, 2023
@jecluis jecluis requested review from votdev and m-ildefons July 30, 2023 11:17
Copy link
Contributor

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing a mention in the values.yaml file, but in principle ok.

@jecluis
Copy link
Contributor Author

jecluis commented Oct 24, 2023

better to adjust the values.yaml file to include a reference to this option before merging.

@jecluis jecluis self-assigned this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Change that positively impacts existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants