Skip to content

Commit

Permalink
v0.3.3
Browse files Browse the repository at this point in the history
Hotfix for #44 
* fix customization issue
* update version to v0.3.3 in package.json, readme,
* add details to changelog
  • Loading branch information
ryanraposo authored May 28, 2022
1 parent 0aedc5f commit 871f660
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 9 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## [0.3.3]

- Fixed issue where customizations would only apply if there was an existing entry for "workbench.colorCustomizations" in settings.

## [0.3.2]

- Fixed elements not showing full names in Palette view.
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

Customize your color theme for VS Code.

[![Version](https://img.shields.io/badge/version-0.3.2-red)]()
[![Version](https://img.shields.io/badge/version-0.3.3-red)]()
[![License](https://img.shields.io/badge/license-MIT-blue.svg)]()

[![LoveIt;ShipIt](https://gitlab.com/ryanraposo/LoveItShipIt/-/raw/master/sticker/loveitshipit.svg)](http://github.com/ryanraposo/LoveItShipIt)
Expand Down Expand Up @@ -59,7 +59,7 @@ The recommended method for installing CodeUI is via the Extension Marketplace, a
Alternatively, you can download the VSIX from [releases](https://github.com/ryanraposo/codeui/releases) and install using the terminal with command:

```
code --install-extension codeui-0.3.2.vsix
code --install-extension codeui-0.3.3.vsix
```

*Note: it may be necessary to reload vscode if installing via the terminal.*
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "SEE LICENSE IN LICENSE.md",
"description": "Customize your color theme for VS Code.",
"icon": "resources/marketplace/codeui-128.png",
"version": "0.3.2",
"version": "0.3.3",
"preview": true,
"galleryBanner": {
"color": "#18191e",
Expand Down
20 changes: 14 additions & 6 deletions src/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,21 @@ class Config {
}

getWorkbenchColorCustomizations(scope: vscode.ConfigurationTarget) {
const customizations = this.config.inspect('workbench.colorCustomizations');
if (customizations) {
return scope == vscode.ConfigurationTarget.Global
? customizations.globalValue
: customizations.workspaceValue;
const customizationSettingsObj = this.config.inspect('workbench.colorCustomizations');
let workbenchColorCustomizations : any = {};

if (customizationSettingsObj) {
if (scope === vscode.ConfigurationTarget.Global) {
workbenchColorCustomizations = customizationSettingsObj.globalValue;
}
if (scope === vscode.ConfigurationTarget.Workspace) {
workbenchColorCustomizations = customizationSettingsObj.workspaceValue;
}
}
return {};
if (workbenchColorCustomizations === undefined) {
return {};
}
return workbenchColorCustomizations;
}

getWorkspaceRootFolder(): vscode.WorkspaceFolder | undefined {
Expand Down

0 comments on commit 871f660

Please sign in to comment.