Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case when we don't want of an app server #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RaitoBezarius
Copy link

Currently, this NGINX buildpack suppose that we always want to use an app server.

Here is another option to disable the app server so that you can run NGINX on Heroku just for static files (useful when you have a React frontend and want to serve the static assets built by Webpack after the build pass of Node.js buildpack).

What do you think? I can, of course, rebase if needed.

I edited two parts of the script which were better according to ShellCheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant