Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(network): remove dio and implement my own network client #77

Merged
merged 16 commits into from
Nov 2, 2024

Conversation

ryanaidilp
Copy link
Owner

Status

READY

Description

Replace dio with my own implementation of NetworkClient.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@ryanaidilp ryanaidilp added enhancement New feature or request refactor Improvements or changes to code labels Nov 2, 2024
@ryanaidilp ryanaidilp self-assigned this Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.95%. Comparing base (8609bfb) to head (9e5a835).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
...c/core/network/interceptors/retry_interceptor.dart 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
+ Coverage    83.09%   83.95%   +0.85%     
===========================================
  Files          108      101       -7     
  Lines         1840     1789      -51     
===========================================
- Hits          1529     1502      -27     
+ Misses         311      287      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanaidilp ryanaidilp merged commit 168b425 into develop Nov 2, 2024
7 checks passed
@ryanaidilp ryanaidilp deleted the refactor/remove-dio branch November 2, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Improvements or changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant