Updated core.py resolved import of SmilesTokenizer #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @dubeyakshat07, thanks for the contribution. I'm pulling in @pschwllr and @avaucher, since I feel there is no need to import tokenise and model from |
|
Thanks @dubeyakshat07 for the PR! I fail to see what problem your PR fixes a problem. I see that there is a problem in training_scripts/launch_suzuki_miyaura_training.py, and this PR, #14, would fix it. Does that cover your use case? If not, can you indicate how to reproduce the bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the following error