core: make findFilePath more robust #751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lihis
suggested changes
Nov 27, 2024
Do not crash, when asset is missing, just warn about it. Game can work well without missing wav and mp3 files. Also, the crash itself looks a bit mysterious, so now the game prints name of the missing asset. Signed-off-by: David Heidelberg <[email protected]>
okias
force-pushed
the
241126-robust-loading
branch
from
b28711a to
28d71ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not crash, when asset is missing, just warn about it. Game can work well without missing wav and mp3 files.
Also, the crash itself looks a bit mysterious, so now the game prints name of the missing asset.
// this caused pretty headache because I didn't copied the audio files from CD2...