Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross-platform code in favor of accurate exit codes #4372

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Dec 20, 2024

The current setup uses execvp on Linux and exit code 3 on failure on Windows.

I'm guessing execvp is used to return the exit code as accurately as possible, including any signals.

Not sure about the exit code 3 on Windows, but I found this in the Windows documentation. I'm not sure about the details, but I tried just returning 1 on Windows and it works fine as well (as expected). Std also uses exit code 1 for Windows.

@daxpedda daxpedda merged commit f817a79 into rustwasm:main Dec 20, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant